Matt Cain submitting mockup-html-css homework #6
Conversation
|
|
||
| } | ||
|
|
||
| body { |
There was a problem hiding this comment.
Since this applied to everything in the html, you want this to be at the top of your CSS file. Styles cascade down so you typically want the least specific selector at the top of the file, and the most specific at the bottom.
| nav a{ | ||
| font-size: 22px; | ||
| color: #c4c4c4; | ||
| padding: 0px 5px 0px 5px; |
There was a problem hiding this comment.
shorthand way to write this: padding: 0 5px;. That sets the top and bottom to 0, left and right to 5px.
|
|
||
| body { | ||
| font-family: Lato; | ||
| padding: 30px 925px 0px 50px; |
There was a problem hiding this comment.
This is a pretty huge right padding value. Did you mean to add that much space on the entire body?
|
|
||
| h2 { | ||
| font-weight: 500; | ||
| font-style: bold; |
There was a problem hiding this comment.
Bold is an invalid value for font-style. You are basically making this h2 bold by changing the font-weight in the line above.
| font-size: 19px; | ||
| } | ||
|
|
||
| article p::first-letter { |
|
|
||
| footer nav a{ | ||
| color: #ffb782; | ||
| text-decoration: none; |
There was a problem hiding this comment.
You've started to repeat this property over and over throughout the file. Consider creating an anchor a { } selector at the beginning of the file that clears this text-decoration to help keep your code DRY.
No description provided.