Fix of using uninitialized memory 'message'. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update main.c - Fix of using uninitialized memory 'message'.
|
These are global variables. Uninitialized global variables are kept in .bss. Usually, this .bss section is initialized to zero before entering to main(). However, it sometimes depends on the toolchain. What toolchain are you using? |
|
I see your point. Currently I use Visual Studio.
Amway I think it would be good to make sure to initialize it explicitly to avoid warning, make code cleaner and safer.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
From: Wojciech ***@***.***>
Sent: středa 30. srpna 2023 18:25
To: ***@***.***>
Cc: ***@***.***>; ***@***.***>
Subject: Re: [wdomski/SX1278-example] Fix of using uninitialized memory 'message'. (PR #8)
These are global variables. Uninitialized global variables are kept in .bss. Usually, this .bss section is initialized to zero before entering to main(). However, it sometimes depends on the toolchain. What toolchain are you using?
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AANQS2IEO4VPI3SMVSZFY53XX5SQBANCNFSM6AAAAAA4ETRSAI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
If you would like to add your change please consider fixing also other variables. There are not that many. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update main.c - Fix of using uninitialized memory 'message'.