feat: [RELEASE] improved InvalidTransition error to include aggregate_id #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desheikh
reviewed
Apr 18, 2024
| @@ -22,6 +22,16 @@ | |||
| event.class, :count | |||
| ) | |||
| end | |||
|
|
|||
| it 'raises an event with the correct error message' do | |||
| allow(Eventsimple::InvalidTransition).to receive(:new).and_call_original | |||
There was a problem hiding this comment.
I don't think we need to stub this
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This issue has been automatically closed because it has had no activity for over 90 days. Please re-open if you feel this was done in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Right now the failure is a bit hard to debug just from the error because we have to track down how it got there via logs and without the ID its a little hard to track down
What changed
Include the
aggregate_idin the message for easy debugging.