fix: actions artifacts upload/download to v4, #141

weaponsforge · Sep 27, 2024 · b62e5c0 · b62e5c0
1 parent 55a657c
commit b62e5c0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/deploy-dev.yml b/.github/workflows/deploy-dev.yml
@@ -1,5 +1,4 @@
-
-name: Deploy to Firebase Hosting
+name: Development - Deploy to Firebase Hosting
 
 # This workflow deploys the static-generated nextjs app to Firebase Hosting
 # Triggered by push to the "dev" branch
@@ -21,6 +20,8 @@ jobs:
     steps:
       - name: Checkout the repository
         uses: actions/checkout@v3
+        with:
+          ref: 'dev'
       - name: Use NodeJS v16.14.2
         uses: actions/setup-node@v3
         with:
@@ -38,9 +39,10 @@ jobs:
           cd client
           npm run export
       - name: Archive Development Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: dev-app
+          include-hidden-files: true
           path: |
             client/out
             client/firebase.json
@@ -53,7 +55,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: dev-app
       - name: Deploy to Firebase

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -19,6 +19,8 @@ jobs:
     steps:
       - name: Checkout the repository
         uses: actions/checkout@v3
+        with:
+          ref: ${{ github.event.release.tag_name }}
       - name: Use NodeJS v16.14.2
         uses: actions/setup-node@v3
         with:
@@ -39,9 +41,10 @@ jobs:
       - name: Disable Jekyll
         run: touch client/out/.nojekyll
       - name: Archive Development Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: main-out
+          include-hidden-files: true
           path: client/out
           retention-days: 3
 
@@ -51,7 +54,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download Artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: main-out
       - name: List files for publish