This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
FEED-206: Fixed that there are no duplicate individual feedback requests are made #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redmerloen
force-pushed
the
feature/individual-feedback-algorithm
branch
from
b3d2756 to
2248551
Compare
redmerloen
force-pushed
the
feature/individual-feedback-algorithm
branch
from
2248551 to
fee3618
Compare
ferdynice
approved these changes
Oct 29, 2018
| @@ -403,6 +409,9 @@ def _match_individual_feedback_to_senders(self, feedbacks): | |||
| # Get first object from the list. | |||
| feedback = feedbacks[0] | |||
|
|
|||
| if feedback.recipient.id not in self.already_received_individual_feedback_by_user: | |||
| self.already_received_individual_feedback_by_user[feedback.recipient.id] = [] | |||
There was a problem hiding this comment.
I would use set() for this.
| @@ -153,6 +155,8 @@ def do_all_users_have_a_role(self): | |||
| return users_without_role | |||
|
|
|||
| def do_all_users_have_a_slack_id(self): | |||
| if settings.SILENT_RUN: | |||
There was a problem hiding this comment.
This change is not needed here. If you run into an error, please put it on the more appropiate place. This function simply returns all users without a slack id, but it does not connect to Slack in any way. So DRY_RUN should only be used on places where actual Slack communication is used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.