Add editable? check for collections for assoc-some fast path #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Could you change the commit message to: |
tomdl89
force-pushed
the
check-editable-for-assoc-some
branch
from
1b6461a to
631247f
Compare
|
I've changed the commit message to what you suggested, plus the word |
Fix assoc-some for collections which cannot be made transient. Closes weavejester#91.
tomdl89
force-pushed
the
check-editable-for-assoc-some
branch
from
631247f to
f019754
Compare
|
Whoops! Thanks for the typo correction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91