Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync functionality #14

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add sync functionality #14

merged 2 commits into from
Oct 26, 2023

Conversation

sarataha
Copy link
Member

@sarataha sarataha force-pushed the sync branch 2 times, most recently from e760cac to 6aed758 Compare October 23, 2023 10:35
@sarataha sarataha marked this pull request as ready for review October 23, 2023 10:35
@sarataha sarataha requested review from foot and bigkevmcd October 23, 2023 10:36
foot
foot approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl annotate automatedclusterdiscovery aks-cluster-discovery "reconcile.fluxcd.io/requestedAt"=foo

  • ✅ Triggers a reconciliation
  • ✅ updates lastHandledReconcileAt: foo

@foot
Copy link
Collaborator

foot commented Oct 23, 2023 •
edited
Loading

Ah! If the reconcilation fails... it would still be nice to update the status too.

  • Tested updating the subId to a bad value
  • waiting for it to settle
  • annotated the ACD
  • triggers a reconcilation
  • BUT lastHandledReconcileAt: foo is not updated in the status. (when it should be, I think)

Lets add a test for that?

  • Update the mockAks thing so that it returns an error
  • Make sure the status is still updated

bigkevmcd
bigkevmcd approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@foot foot merged commit 0ba7ecd into main Oct 26, 2023
3 checks passed
@foot foot deleted the sync branch October 26, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd approved these changes

@foot foot foot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cluster-reflector] Add sync/suspend/resume support to CRD and controller
3 participants
@sarataha @foot @bigkevmcd