Add status.Conditions - ready with count of reflected clusters #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
reviewed
Oct 27, 2023
foot
reviewed
Oct 27, 2023
| if inventoryRefs != nil { | ||
| logger.Info("reconciled clusters", "count", len(inventoryRefs)) | ||
| clustersv1alpha1.SetAutomatedClusterDiscoveryReadiness(clusterDiscovery, clusterDiscovery.Status.Inventory, metav1.ConditionTrue, clustersv1alpha1.ReconciliationSucceededReason, | ||
| fmt.Sprintf("%d resources found", len(inventoryRefs))) |
There was a problem hiding this comment.
I think "resources created" as thats what were doing, or?
There was a problem hiding this comment.
How about we actually just reflect the number of clusters?
And make it %d clusters discovered ?
foot
reviewed
Oct 27, 2023
|
|
||
| if err = r.patchStatus(ctx, req, clusterDiscovery.Status); err != nil { | ||
| return ctrl.Result{}, err | ||
| } |
There was a problem hiding this comment.
Nice! So with the repetition here it might be time to pull out the generation stuff into a reconcileResources function as we have in gitopssets, and then only patch the status once for err and once for success etc
bigkevmcd
reviewed
Nov 1, 2023
| // ObservedGeneration is the last observed generation of the | ||
| // object. | ||
| // +optional | ||
| ObservedGeneration int64 `json:"observedGeneration,omitempty"` |
There was a problem hiding this comment.
There's a bug I need to fix in GitOpsSets, the ObservedGeneration should default to -1
You'll need to change it like this:
Spec AutomatedClusterDiscoverySpec `json:"spec,omitempty"`
// +kubebuilder:default={"observedGeneration":-1}
Status AutomatedClusterDiscoveryStatus `json:"status,omitempty"`
bigkevmcd
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: weaveworks/weave-gitops-enterprise#3515
PR to add readiness status for reflected clusters, it also includes messages for success/failure and a count of created resources. This allows users to easily check if a cluster is ready through the UI and
kubectl.