Adds more debug logging to help figure out OIDC/RBAC issues #3308
+190
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We log out the namespaces we've guessed a user has access to so if thats quite wrong we can go straight to investigating RBAC - Include user a bit more in the logs too - Remove "attempt to read token from auth header" as its not that useful
bigkevmcd
reviewed
Jan 25, 2023
- Again remove the JWTAuthorizationHeaderPrincipalGetter debug statement, its not very useful
makkes
reviewed
Jan 30, 2023
bigkevmcd
reviewed
Feb 1, 2023
core/clustersmngr/factory.go
Outdated
| return client, nil | ||
| } | ||
|
|
||
| // Format the namespaces as a map[clusterName][]namespacesNames |
There was a problem hiding this comment.
Will this scale?
What if you have 100+ namespaces? 1000+ ?
For clarity, 1000+ is not uncommon
There was a problem hiding this comment.
Good question. For the scenarios we've been exploring ~10-15 namespaces its been a real help. But for 1000 I guess some part of your logging system might get grumpy.
{ "myCluster": { "namespaces": ["foo", "bar"], "totalCount": "3" } # show a sensible N namespaces and report the total count
I don't know if the structured logging has nested structures in mind..
The count alone would still be useful.
|
@foot Is this still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why was this change made?
Make it easier to debug why things may be missing on the apps/sources etc pages
How was this change implemented?
Adding more logging
How did you validate the change?
Manually
Examples
{"level":"debug","ts":1674665219.1867902,"logger":"gitops","caller":"clustersmngr/factory.go:386","msg":"Updated namespaces cache","namespaces":{"default/vcluster":["default","kube-system","kube-public","kube-node-lease","flux-system"],"management":[]}} {"level":"error","ts":1674665219.1871428,"logger":"gitops","caller":"clustersmngr/factory.go:595","msg":"error updating namespaces from user client","user":"id=\"alice\" groups=[foo] tokenLength=922","error":"1 error occurred:\n\t* Failed to list resource on cluster=\"management\" namespace=\"\" err=\"namespaces is forbidden: User \\\"alice\\\" cannot list resource \\\"namespaces\\\" in API group \\\"\\\" at the cluster scope\"\n\n"} {"level":"debug","ts":1674665219.2782335,"logger":"gitops","caller":"clustersmngr/factory.go:603","msg":"Updated namespace access cache for user","userNamespaces":{"default/vcluster":["flux-system"],"management":[]},"user":"id=\"alice\" groups=[foo] tokenLength=922","ttl":"30s"}