Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest flux version for Flux discovery. #4166

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

bigkevmcd
Copy link
Contributor

@bigkevmcd bigkevmcd commented Dec 12, 2023

Closes

What changed?
This adds the latest source-controller v1.2.2 as a marker for Flux v2.1.2.

Dependencies are updated, and code updated to reflect the updates to dependencies.

This requires upstream changes in tf-controller (because of updates to the Flux dependencies).

Why was this change made?
To support the latest version of Flux when the version isn't on the namespace.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@bigkevmcd bigkevmcd requested a review from foot December 12, 2023 13:03
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 6 times, most recently from ddbd89b to df0361c Compare December 13, 2023 08:53
core/server/inventory.go Outdated Show resolved Hide resolved
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 4 times, most recently from 66670cf to da9ac91 Compare December 13, 2023 14:06
core/server/inventory.go Outdated Show resolved Hide resolved
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 3 times, most recently from d4ccfa8 to ecc9b2a Compare December 14, 2023 10:47
core/server/inventory.go Show resolved Hide resolved
core/server/inventory.go Outdated Show resolved Hide resolved
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 2 times, most recently from 76a9930 to 9fc9cce Compare December 15, 2023 12:15
core/server/inventory.go Outdated Show resolved Hide resolved
core/server/inventory.go Outdated Show resolved Hide resolved
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 3 times, most recently from afd1cd4 to 57cdc0a Compare December 18, 2023 13:50
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a Flux perspective, changes now look all good to me 💯

This adds the latest source-controller v1.2.2 as a marker for Flux
v2.1.2.

Dependencies are updated to allow us to pull in the latest Flux code.

And we now pull the internal Helm release storage version from the
history, rather than the latest version field.

If there's no history, we retain the old version.
@bigkevmcd bigkevmcd merged commit 591cc3d into main Dec 30, 2023
15 of 16 checks passed
@bigkevmcd bigkevmcd deleted the add-new-flux-version branch December 30, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants