-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest flux version for Flux discovery. #4166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
approved these changes
Dec 12, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
6 times, most recently
from
December 13, 2023 08:53
ddbd89b
to
df0361c
Compare
foot
reviewed
Dec 13, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
4 times, most recently
from
December 13, 2023 14:06
66670cf
to
da9ac91
Compare
hiddeco
reviewed
Dec 13, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
3 times, most recently
from
December 14, 2023 10:47
d4ccfa8
to
ecc9b2a
Compare
hiddeco
reviewed
Dec 15, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
2 times, most recently
from
December 15, 2023 12:15
76a9930
to
9fc9cce
Compare
hiddeco
reviewed
Dec 15, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
from
December 15, 2023 14:10
9fc9cce
to
acd66aa
Compare
hiddeco
reviewed
Dec 15, 2023
bigkevmcd
force-pushed
the
add-new-flux-version
branch
3 times, most recently
from
December 18, 2023 13:50
afd1cd4
to
57cdc0a
Compare
hiddeco
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a Flux perspective, changes now look all good to me 💯
This adds the latest source-controller v1.2.2 as a marker for Flux v2.1.2. Dependencies are updated to allow us to pull in the latest Flux code. And we now pull the internal Helm release storage version from the history, rather than the latest version field. If there's no history, we retain the old version.
bigkevmcd
force-pushed
the
add-new-flux-version
branch
from
December 30, 2023 13:16
e0b62c7
to
6b19c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
This adds the latest source-controller v1.2.2 as a marker for Flux v2.1.2.
Dependencies are updated, and code updated to reflect the updates to dependencies.
This requires upstream changes in tf-controller (because of updates to the Flux dependencies).
Why was this change made?
To support the latest version of Flux when the version isn't on the namespace.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes