Add deletion strategy option when creating classes #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlmanrique
force-pushed
the
rodrigo/delete_on_conflict
branch
2 times, most recently
from
ab59303 to
25f43e5
Compare
Signed-off-by: Rodrigo Lopez <[email protected]>
rlmanrique
force-pushed
the
rodrigo/delete_on_conflict
branch
from
25f43e5 to
b6d8cd8
Compare
|
Ready for review and merge |
|
If I recall correctly I remember Jero saying at the beginning that this option could be enabled when updating a class, could you also add it into the update_collection logic? |
Oh, I didn't know about it. Let me try it out! |
rlmanrique
force-pushed
the
rodrigo/delete_on_conflict
branch
2 times, most recently
from
c1f832c to
391386b
Compare
|
ok, completed, including the update of the collection. I tested it and works. Thanks for the idea! Ready to be merged |
|
Great to see you again! Thanks for the contribution. |
rlmanrique
force-pushed
the
rodrigo/delete_on_conflict
branch
from
391386b to
0f16511
Compare
jfrancoa
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to set the deletion strategy when creating a collection.