-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlocks and races in multi-threaded asyncio logic #747
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## beta/v4.0 #747 +/- ##
=============================================
- Coverage 89.38% 89.18% -0.20%
=============================================
Files 154 177 +23
Lines 16747 18029 +1282
=============================================
+ Hits 14970 16080 +1110
- Misses 1777 1949 +172 ☔ View full report in Codecov by Sentry. |
Great to see you again! Thanks for the contribution. |
This PR fixes a host of multi-threading event loop problems by simplifying the logic around creating new event loops and spawning them in threads. Now, the batching code handles its own internal event loop outside of any main thread loop and does so entirely within the context of the background batching thread