NFC-47 NFC support for web-eid example

[SanderKondratjevNortal]

Signed-off-by: Sander Kondratjev [email protected]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mrts]

Looks good to me now apart from the suggested changes, thanks for your great work!

As discussed, also consider making mobile code configurable both to make it easier to discern and possibly serve a real business need not to use it in certain circumstances.

[mrts]

As discussed, let's use Thymeleaf to avoid the somewhat fragile String.format() and keep HTML out of Java files. The HTML should be moved to resources/templates/webeid-login.html.

[mrts]

For Thymeleaf support:

Suggested change

	public WebEidLoginPageGeneratingFilter(String path, String loginProcessingPath) {
	this.requestMatcher = PathPatternRequestMatcher.withDefaults().matcher(HttpMethod.GET, path);
	this.loginProcessingPath = loginProcessingPath;
	public WebEidLoginPageGeneratingFilter(String path, String loginProcessingPath, ITemplateEngine templateEngine, JakartaServletWebApplication webApp) {
	this.requestMatcher = PathPatternRequestMatcher.withDefaults().matcher(HttpMethod.GET, path);
	this.loginProcessingPath = loginProcessingPath;
	this.templateEngine = templateEngine;
	this.webApp = webApp;

And add fields above:

    private final ITemplateEngine templateEngine;
    private final JakartaServletWebApplication webApp;

[mrts]

Suggested change

	private String generateHtml(CsrfToken csrf) {
	return String.format(
	LOGIN_PAGE_HTML,
	loginProcessingPath,
	csrf != null ? csrf.getHeaderName() : "X-CSRF-TOKEN",
	csrf != null ? csrf.getToken() : ""
	private String renderTemplate(HttpServletRequest request, HttpServletResponse response, CsrfToken csrf) {
	IWebExchange exchange = webApp.buildExchange(request, response);
	var locale = RequestContextUtils.getLocale(request);
	var ctx = new WebContext(exchange, locale);
	ctx.setVariable("loginProcessingPath", loginProcessingPath);
	ctx.setVariable("csrfHeaderName", csrf != null ? csrf.getHeaderName() : "X-CSRF-TOKEN");
	ctx.setVariable("csrfToken", csrf != null ? csrf.getToken() : "");
	return templateEngine.process("webeid-login", ctx);

and add import org.springframework.web.servlet.support.RequestContextUtils.

[mrts]

Suggested change

	String html = generateHtml(csrf);
	response.setContentType(MediaType.TEXT_HTML_VALUE);
	String html = renderTemplate(request, response, csrf);
	response.setCharacterEncoding(StandardCharsets.UTF_8.name());
	response.setContentType(MediaType.TEXT_HTML_VALUE);