feat: support remove plugin (#677)

* feat: support remove plugin * fix: fix error * chore: add changeset * chore: remove changeset --------- Co-authored-by: nyqykk <[email protected]>
web-infra-dev · Jul 16, 2024 · c38d6fe · c38d6fe
1 parent 6d8ac4d
commit c38d6fe
Show file tree

Hide file tree

Showing 4 changed files with 5,469 additions and 6,120 deletions.
diff --git a/package.json b/package.json
@@ -20,7 +20,6 @@
     "cy:open": "cypress open --config-file=cypress.config.ts",
     "cy:run": "cypress run",
     "type:check": "tsc -noEmit",
-    "changeset": "npx changeset",
     "reset": "pnpm -r exec -- rm -rf node_modules && pnpm -r exec -- rm -rf dist && rm -rf node_modules",
     "setup": "cross-env DISABLE_GARFISH_CHECK_INTERNAL=true pnpm install",
     "ls-lint": "ls-lint",

diff --git a/packages/core/src/garfish.ts b/packages/core/src/garfish.ts
@@ -95,6 +95,10 @@ export class Garfish extends EventEmitter2 {
     return this;
   }
 
+  removePlugin(pluginName: string) {
+    this.hooks.removePlugin(pluginName);
+  }
+
   run(options: interfaces.Options = {}) {
     if (this.running) {
       if (__DEV__) {

diff --git a/packages/hooks/src/pluginSystem.ts b/packages/hooks/src/pluginSystem.ts
@@ -43,9 +43,11 @@ export class PluginSystem<T extends Record<string, any>> {
     const plugin = this.registerPlugins[pluginName];
     assert(plugin, `plugin "${pluginName}" is not registered.`);
 
-    for (const key in plugin) {
-      if (key === 'name') continue;
-      this.lifecycle[key].remove(plugin[key as string]);
+    for (const key in this.lifecycle) {
+      const pluginLife = plugin[key as string];
+      if (pluginLife) {
+        this.lifecycle[key].remove(pluginLife);
+      }
     }
   }