feat(web-integration): update text element handling to use parent node attributes and content #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
quanru
force-pushed
the
feat/use-text-parent-node
branch
from
b6b17d1 to
18494c7
Compare
quanru
force-pushed
the
feat/use-text-parent-node
branch
from
18494c7 to
bcab5e8
Compare
zhoushaw
reviewed
May 10, 2025
| @@ -2130,7 +2195,48 @@ exports[`extractor > basic 2`] = ` | |||
| "htmlTagName": "<body>", | |||
| "nodeType": "TEXT Node", | |||
| }, | |||
| "content": "phrase "The quick brown fox jumps over the lazy dog" is a well-known English-language pangram, meaning it contains every letter of the alphabet at least once. This sentence has become a standard tool for various applications, particularly in typing practice, font display, and keyboard testing. The phrase has permeated popular culture and is referenced in various media, including literature and film. Its simplicity and utility have made it a staple in educational contexts and beyond. For instance, it was famously used as the first message sent over the Moscow–Washington hotline in 19634.", | |||
| "content": "Data Record | |||
There was a problem hiding this comment.
It seems abnormal. We should only collect child nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.