Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting NODE_ENV from env files #2915

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jul 13, 2024

Summary

dotenv-expand does not override existing env vars by default, but we should allow overriding NODE_ENV, which is very common.

Related Links

resolve #2904
motdotla/dotenv#199

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 84b433e
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66923577da5eda0008764990
😎 Deploy Preview https://deploy-preview-2915--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 89da321 into main Jul 13, 2024
10 checks passed
@chenjiahan chenjiahan deleted the env_node_env_0713 branch July 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: --env-mode can‘t change the process.env.NODE_ENV environment variable.
1 participant