feat(core): add distPath.assets and filename.assets
#3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
😂 Strictly speaking, images svgs etc are also called |
SoonIter
changed the title
SoonIter
changed the title
distPath.assets and output.filename.assets
SoonIter
changed the title
distPath.assets and output.filename.assetsdistPath.assets and filename.assets
chenjiahan
reviewed
Oct 12, 2024
chenjiahan
reviewed
Oct 12, 2024
chenjiahan
reviewed
Oct 12, 2024
Haha, all of them are assets, we have categorized the assets into subdirectories, which isn't bad. |
chenjiahan
reviewed
Oct 12, 2024
| @@ -55,6 +57,7 @@ const prodDefaultFilename = { | |||
| - `font`：表示字体文件的名称。 | |||
| - `image`：表示非 SVG 图片的名称。 | |||
| - `media`：表示视频等媒体资源的名称。 | |||
| - `assets`：表示除了上述类型之外，其他命中 `asset/resource` 的文件名称。 | |||
There was a problem hiding this comment.
How about linking to the Asset Module documentation?
The same as output.assetModuleFilename
Suggested change
| - `assets`：表示除了上述类型之外，其他命中 `asset/resource` 的文件名称。 | |
| - `assets`：表示除了上述类型之外，其他命中 [Asset Modules](https://rspack.dev/guide/features/asset-module) 规则的文件名称。 |
Co-authored-by: neverland <[email protected]>
Co-authored-by: neverland <[email protected]>
chenjiahan
reviewed
Oct 13, 2024
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat(core): add
distPath.assetsandoutput.filename.assetsRelated Links
close #3650
Checklist