Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declare __dirname for Node.js ES modules #3782

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: declare __dirname for Node.js ES modules #3782

merged 1 commit into from
Oct 21, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 21, 2024

Summary

Declare __dirname for Node.js ES modules as Rslib no longer inject the __dirname shim by default.

Related Links

web-infra-dev/rslib#291
https://stackoverflow.com/questions/46745014/alternative-for-dirname-in-node-js-when-using-es6-modules
close #3777

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f12a964
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67161abcb9701500095c0478
😎 Deploy Preview https://deploy-preview-3782--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit c1791b8 into main Oct 21, 2024
11 checks passed
@chenjiahan chenjiahan deleted the rslib_013 branch October 21, 2024 09:21
@chenjiahan chenjiahan mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant