Skip to content

Commit

Permalink
chore: add todo
Browse files Browse the repository at this point in the history
  • Loading branch information
nyqykk committed Oct 16, 2024
1 parent d5d5056 commit 0ff4265
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/core/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ const composeFormatConfig = (
output: {
uniqueName: pkgJson.name as string,
},
// TODO when we provide dev mode for rslib mf format, this should be modified to as the same with config.mode
// can not set nodeEnv to false, because mf format should build shared module.
// If nodeEnv is false, the process.env.NODE_ENV in third-party packages's will not be replaced
// now we have not provide dev mode for users, so we can always set nodeEnv as 'production'
Expand Down

0 comments on commit 0ff4265

Please sign in to comment.