fix(minify): only preserve some comments and annotations by default

web-infra-dev · Dec 12, 2024 · 10fb850 · 10fb850
1 parent aa4c5f3
commit 10fb850
Show file tree

Hide file tree

Showing 30 changed files with 297 additions and 226 deletions.
diff --git a/examples/module-federation/mf-host/package.json b/examples/module-federation/mf-host/package.json
@@ -13,7 +13,7 @@
   },
   "devDependencies": {
     "@module-federation/rsbuild-plugin": "^0.8.1",
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.1.0",
     "@types/react": "^19.0.1",
     "@types/react-dom": "^19.0.2",

diff --git a/examples/module-federation/mf-remote/package.json b/examples/module-federation/mf-remote/package.json
@@ -13,7 +13,7 @@
   },
   "devDependencies": {
     "@module-federation/rsbuild-plugin": "^0.8.1",
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.1.0",
     "@types/react": "^19.0.1",
     "@types/react-dom": "^19.0.2",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -37,7 +37,7 @@
     "prebundle": "prebundle"
   },
   "dependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "rsbuild-plugin-dts": "workspace:*",
     "tinyglobby": "^0.2.10"
   },

diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -339,7 +339,8 @@ export function composeMinifyConfig(config: LibConfig): RsbuildConfig {
               toplevel: format !== 'mf',
             },
             format: {
-              comments: 'all',
+              comments: 'some',
+              preserve_annotations: true,
             },
           },
         },

diff --git a/packages/core/tests/__snapshots__/config.test.ts.snap b/packages/core/tests/__snapshots__/config.test.ts.snap
@@ -90,7 +90,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
                 "unused": true,
               },
               "format": {
-                "comments": "all",
+                "comments": "some",
+                "preserve_annotations": true,
               },
               "mangle": false,
               "minify": false,
@@ -327,7 +328,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
                 "unused": true,
               },
               "format": {
-                "comments": "all",
+                "comments": "some",
+                "preserve_annotations": true,
               },
               "mangle": false,
               "minify": false,
@@ -557,7 +559,8 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
                 "unused": true,
               },
               "format": {
-                "comments": "all",
+                "comments": "some",
+                "preserve_annotations": true,
               },
               "mangle": false,
               "minify": false,

diff --git a/packages/core/tests/config.test.ts b/packages/core/tests/config.test.ts
@@ -331,7 +331,8 @@ describe('minify', () => {
               "unused": true,
             },
             "format": {
-              "comments": "all",
+              "comments": "some",
+              "preserve_annotations": true,
             },
             "mangle": false,
             "minify": false,

diff --git a/packages/create-rslib/fragments/tools/storybook-react-js/package.json b/packages/create-rslib/fragments/tools/storybook-react-js/package.json
@@ -4,7 +4,7 @@
     "storybook": "storybook dev"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@storybook/addon-essentials": "^8.4.7",
     "@storybook/addon-interactions": "^8.4.7",
     "@storybook/addon-links": "^8.4.7",

diff --git a/packages/create-rslib/fragments/tools/storybook-react-ts/package.json b/packages/create-rslib/fragments/tools/storybook-react-ts/package.json
@@ -4,7 +4,7 @@
     "storybook": "storybook dev"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@storybook/addon-essentials": "^8.4.7",
     "@storybook/addon-interactions": "^8.4.7",
     "@storybook/addon-links": "^8.4.7",

diff --git a/packages/create-rslib/template-[react]-[storybook,vitest]-js/package.json b/packages/create-rslib/template-[react]-[storybook,vitest]-js/package.json
@@ -19,7 +19,7 @@
     "test": "vitest run"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.0.7",
     "@rslib/core": "workspace:*",
     "@storybook/addon-essentials": "^8.4.7",

diff --git a/packages/create-rslib/template-[react]-[storybook,vitest]-ts/package.json b/packages/create-rslib/template-[react]-[storybook,vitest]-ts/package.json
@@ -21,7 +21,7 @@
     "test": "vitest run"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.0.7",
     "@rslib/core": "workspace:*",
     "@storybook/addon-essentials": "^8.4.7",

diff --git a/packages/create-rslib/template-[react]-[storybook]-js/package.json b/packages/create-rslib/template-[react]-[storybook]-js/package.json
@@ -18,7 +18,7 @@
     "storybook": "storybook dev"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.0.7",
     "@rslib/core": "workspace:*",
     "@storybook/addon-essentials": "^8.4.7",

diff --git a/packages/create-rslib/template-[react]-[storybook]-ts/package.json b/packages/create-rslib/template-[react]-[storybook]-ts/package.json
@@ -20,7 +20,7 @@
     "storybook": "storybook dev"
   },
   "devDependencies": {
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rsbuild/plugin-react": "^1.0.7",
     "@rslib/core": "workspace:*",
     "@storybook/addon-essentials": "^8.4.7",

diff --git a/packages/plugin-dts/package.json b/packages/plugin-dts/package.json
@@ -35,7 +35,7 @@
   },
   "devDependencies": {
     "@microsoft/api-extractor": "^7.48.0",
-    "@rsbuild/core": "~1.1.9",
+    "@rsbuild/core": "~1.1.10",
     "@rslib/tsconfig": "workspace:*",
     "rslib": "npm:@rslib/[email protected]",
     "typescript": "^5.6.3"