chore: add isObject util

web-infra-dev · Aug 9, 2024 · 3f24d59 · 3f24d59
1 parent 6fce2ed
commit 3f24d59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -25,6 +25,7 @@ import { getDefaultExtension } from './utils/extension';
 import {
   calcLongestCommonPath,
   color,
+  isObject,
   nodeBuiltInModules,
   readPackageJson,
 } from './utils/helper';
@@ -111,10 +112,7 @@ export const composeAutoExternalConfig = (options: {
   // eg: autoExternal: ['react'], user: output: { externals: { react: 'react-1' } }
   // Only handle the case where the externals type is object, string / string[] does not need to be processed, other types are too complex.
   const userExternalKeys =
-    userExternals &&
-    Object.prototype.toString.call(userExternals) === '[object Object]'
-      ? Object.keys(userExternals)
-      : [];
+    userExternals && isObject(userExternals) ? Object.keys(userExternals) : [];
 
   const externals = (
     ['dependencies', 'peerDependencies', 'devDependencies'] as const

diff --git a/packages/core/src/utils/helper.ts b/packages/core/src/utils/helper.ts
@@ -118,4 +118,7 @@ export const readPackageJson = (rootPath: string): undefined | PkgJson => {
   }
 };
 
+export const isObject = (obj: unknown): obj is Record<string, any> =>
+  Object.prototype.toString.call(obj) === '[object Object]';
+
 export { color, calcLongestCommonPath };