Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: the minify options comments: "some" does not preserve pure annotation #418

Closed
fi3ework opened this issue Nov 13, 2024 · 0 comments · Fixed by web-infra-dev/rspack#8628 or #522
Closed

[Bug]: the minify options comments: "some" does not preserve pure annotation #418

fi3ework opened this issue Nov 13, 2024 · 0 comments · Fixed by web-infra-dev/rspack#8628 or #522
Assignees
@fi3ework
Labels
🐞 bug Something isn't working

Comments

@fi3ework
Copy link
Member

fi3ework commented Nov 13, 2024 •
edited
Loading

Version

latest

Details

Change this line

rslib/packages/core/src/config.ts

Line 316 in dacb1d2

comments: 'all',
to comments: 'some'. The pure annotation will be striped.

It works as expected in swc playground. Seems to be a Rspack bug.

Reproduce link

/

Reproduce Steps

Simply check the react bundleless example in /examples after change to 'some'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fi3ework fi3ework

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@fi3ework