Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minify): only preserve some comments and annotations by default #522

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Dec 5, 2024

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 14aa4e6
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/675bfb65dee9fc0008e078e7
😎 Deploy Preview https://deploy-preview-522--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework marked this pull request as ready for review December 12, 2024 12:33
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #522 will not alter performance

Comparing minify-some (14aa4e6) with main (12b6578)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework enabled auto-merge (squash) December 13, 2024 03:08
@fi3ework fi3ework merged commit 5f420f0 into main Dec 13, 2024
19 checks passed
@fi3ework fi3ework deleted the minify-some branch December 13, 2024 09:27
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the minify options comments: "some" does not preserve pure annotation
2 participants