Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add prettier-plugin-packagejson #13

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore: add prettier-plugin-packagejson #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"singleQuote": true
"singleQuote": true,
"plugins": ["prettier-plugin-packagejson"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this.

}
6 changes: 3 additions & 3 deletions e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"name": "@rslib/e2e",
"private": true,
"type": "module",
"scripts": {
"test": "playwright test"
},
"imports": {
"#helper": "./scripts/helper.ts"
},
"scripts": {
"test": "playwright test"
},
"devDependencies": {
"@playwright/test": "1.43.1",
"@rslib/core": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"cross-env": "^7.0.3",
"nano-staged": "^0.8.0",
"prettier": "^3.2.4",
"prettier-plugin-packagejson": "^2.5.0",
"simple-git-hooks": "^2.10.0",
"vitest": "^1.5.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
},
"dependencies": {
"@rsbuild/core": "0.6.2",
"@rsbuild/shared": "0.6.2",
"commander": "^12.0.0"
"@rsbuild/shared": "0.6.2"
},
"devDependencies": {
"@rslib/tsconfig": "workspace:*",
"commander": "^12.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commander is set to be prebundled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in the future this package will be precompiled just like Rsbuild do

"typescript": "^5.4.5"
},
"engines": {
Expand Down
88 changes: 85 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading