Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic support of asset bundleless #221

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Sep 20, 2024

Summary

closes: #217

This pr implements basic support of assets in bundleless mode:

  • Filter the glob resolved entry files based on the allowed extensions, inclulding js/css/json, asset extension is ignored from entry
  • For bundleless external logic, we only check relative path import of js extensions
  • Assets are processed by loader, so path is already correct and we do not need to redirect asset path [Feature]: Redirect in bundleless mode #140

We need to do #219 after this.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit e23c099
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/66f0e8dd59217b0008b9c55e
😎 Deploy Preview https://deploy-preview-221--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

e2e/cases/banner-footer/src/index.ts Show resolved Hide resolved
packages/core/src/constant.ts Show resolved Hide resolved
packages/core/src/constant.ts Outdated Show resolved Hide resolved
packages/core/src/constant.ts Outdated Show resolved Hide resolved
packages/core/src/config.ts Show resolved Hide resolved
@Timeless0911 Timeless0911 merged commit c00525a into main Sep 23, 2024
10 checks passed
@Timeless0911 Timeless0911 deleted the feat/asset-bundleless branch September 23, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support import asset in bundleless mode
2 participants