Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct ECMA version browserslist mapping #301

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: correct ECMA version browserslist mapping #301

merged 1 commit into from
Oct 17, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Oct 16, 2024 •
edited
Loading

Summary

Fix #284.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #301 will not alter performance

Comparing fix-syntax (f1055a9) with main (1b905d8)

Summary

✅ 3 untouched benchmarks

chenjiahan
chenjiahan reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most build tools support es6 as an alias to es2015, can we consider preserving es6 to make this easier to use?

@fi3ework
Copy link
Member Author

Added it back.

@fi3ework fi3ework enabled auto-merge (squash) October 17, 2024 03:30
@fi3ework fi3ework changed the title fix!: correct ECMA version browserslist mapping fix: correct ECMA version browserslist mapping Oct 17, 2024
@fi3ework fi3ework enabled auto-merge (squash) October 17, 2024 03:30
chenjiahan
chenjiahan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fi3ework fi3ework merged commit 96f5983 into main Oct 17, 2024
20 checks passed
@fi3ework fi3ework deleted the fix-syntax branch October 17, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Should not lower function default parameters when using `syntax: 'es2021'
2 participants
@fi3ework @chenjiahan