Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core/loadConfig): loadConfig({ cwd, path}) #84

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 13, 2024

Summary

  1. refactor loadConfig
// before
export async function loadConfig(
  customConfig?: string,
  envMode?: string,
): Promise<RslibConfig> 

// after  https://github.com/web-infra-dev/rsbuild/blob/080a0d856f6743fe1e9570638448a3d629f91dea/packages/core/src/config.ts#L347
export async function loadConfig({
  cwd = process.cwd(),
  path,
  envMode,
}: {
  cwd?: string;
  path?: string;
  envMode?: string;
}): Promise<RslibConfig> 
  1. remove the first arg of generateEsmConfig

@SoonIter SoonIter force-pushed the win-ci branch 4 times, most recently from 83f4c92 to c4d5db3 Compare August 19, 2024 03:01
@SoonIter SoonIter changed the title ci: refactor generateConfig refactor(core/loadConfig): loadConfig({ cwd, path}) Aug 19, 2024
@SoonIter SoonIter marked this pull request as ready for review August 19, 2024 03:28
@SoonIter SoonIter enabled auto-merge (squash) August 19, 2024 03:35
@Timeless0911 Timeless0911 enabled auto-merge (squash) August 19, 2024 03:41
@Timeless0911 Timeless0911 merged commit 74a7ac9 into web-infra-dev:main Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants