chore(cli): add --clean option to build command #87
Conversation
shulaoda
force-pushed
the
chore/cli-clean
branch
from
8737379
to
189356b
Compare
packages/core/src/cli/commands.ts
Outdated
| .description('build the library for production') | ||
| .action(async (options: BuildOptions) => { | ||
| try { | ||
| const rslibConfig = await loadConfig(options.config, options.envMode); | ||
|
|
||
| if (options.clean) { | ||
| const distDir = rslibConfig.output?.distPath?.root ?? OUTPUT_DIST_DIR; |
There was a problem hiding this comment.
It's raw Rslib config, we should get distDir from final Rsbuild environment config.
There was a problem hiding this comment.
Rsbuild already support clean output.cleanDistPath, may be you should implemeny clean feature in plugin-dts, to add an option of clean, and in default rslib core logic, when we use builtin plugin-dts, pass clean: true to it.
There was a problem hiding this comment.
The issue was written early and may have some problems now.
There was a problem hiding this comment.
Would it be confusing to include the clean option in plugin-dts?
There was a problem hiding this comment.
Because clean is a global build option, not plugin-dts.
There was a problem hiding this comment.
Js output will be cleaned according to Rsbuild output.cleanDistPath by default, the DTS output should align with this behaviour. Maybe we don't need a cli option to do that, just in built-in logic.
There was a problem hiding this comment.
Maybe we don't need a cli option to do that, just in built-in logic.
Agree
There was a problem hiding this comment.
However, Rsbuild seems to default to clear dist. What is the significance of doing so? Does plugin-dts not support default clear?
There was a problem hiding this comment.
The dist maybe dirty in local development, clean behavihour can ensure the new output will not be influenced by existed output.
There was a problem hiding this comment.
plugin-dts have not supported it yet.
We should clean:
- bundleless mode: the tsc emit path
- bundle mode: the tsc emit temp path
.rslib/declarationsand api-extractor emit path
|
I have changed the feature issue What do you think about the clean feature? |
shulaoda
force-pushed
the
chore/cli-clean
branch
from
189356b
to
4e20196
Compare
|
I tried to rewrite, but it seems that an empty commit caused PR to close. |
|
Feel free to re-create one and link to this PR. |
Related Links
Related to #46
Checklist