Skip to content

Commit

Permalink
test: disable unstable test case of rspack-cli (#8086)
Browse files Browse the repository at this point in the history
  • Loading branch information
LingyuCoder authored Oct 11, 2024
1 parent 598d44e commit 0683b3e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/rspack-cli/tests/build/issue-6359/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ it("should not have `process.env.WEBPACK_SERVE` set on build mode", async () =>
expect(mainJs).toContain("WEBPACK_SERVE=<EMPTY>");
});

it("should have `process.env.WEBPACK_SERVE` set on serve mode", async () => {
// TODO: this test is not stable on CI, need to fix it
it.skip("should have `process.env.WEBPACK_SERVE` set on serve mode", async () => {
await runWatch(__dirname, ["serve"], { killString: /rspack compiled/i });
// wait 1s to make sure the assets have been generated
await new Promise(resolve => setTimeout(resolve, 1000));
Expand Down

2 comments on commit 0683b3e

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-10-11 598d44e) Current Change
10000_development-mode + exec 2.16 s ± 42 ms 2.16 s ± 41 ms +0.13 %
10000_development-mode_hmr + exec 682 ms ± 13 ms 685 ms ± 5.4 ms +0.43 %
10000_production-mode + exec 2.74 s ± 39 ms 2.75 s ± 23 ms +0.28 %
arco-pro_development-mode + exec 1.84 s ± 93 ms 1.83 s ± 89 ms -0.42 %
arco-pro_development-mode_hmr + exec 436 ms ± 6.2 ms 436 ms ± 3.7 ms -0.07 %
arco-pro_production-mode + exec 3.14 s ± 85 ms 3.11 s ± 111 ms -0.82 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.13 s ± 85 ms 3.19 s ± 77 ms +1.83 %
threejs_development-mode_10x + exec 1.7 s ± 16 ms 1.7 s ± 15 ms +0.38 %
threejs_development-mode_10x_hmr + exec 802 ms ± 9 ms 809 ms ± 12 ms +0.83 %
threejs_production-mode_10x + exec 5.04 s ± 24 ms 5.06 s ± 28 ms +0.52 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ✅ success
devserver ✅ success

Please sign in to comment.