Skip to content

Commit

Permalink
chore(infra): bump pnpm v9 (#6767)
Browse files Browse the repository at this point in the history
* chore(infra): bump pnpm v9

* chore: update npmrc

* fix: pnpm path
  • Loading branch information
chenjiahan authored Jun 11, 2024
1 parent 845deae commit 4fcc42c
Show file tree
Hide file tree
Showing 6 changed files with 13,663 additions and 10,373 deletions.
4 changes: 2 additions & 2 deletions .github/actions/pnpm-cache/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Install Node.js with pnpm global cache

inputs:
node-version:
default: '20'
default: "20"
required: false
type: string
frozen-lockfile:
Expand Down Expand Up @@ -37,7 +37,7 @@ runs:
run: |
# set store-dir to $(pnpm config get store-dir)/$(pnpm -v)
global_store_path=$(pnpm config get store-dir)
if [ -z $global_store_path ]; then
if [ -z "${global_store_path}" ] || [ "${global_store_path}" = "undefined" ]; then
global_store_path=~/.cache/pnpm
fi
pnpm config set store-dir $global_store_path/$(pnpm -v) --location project
Expand Down
3 changes: 0 additions & 3 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
node-linker=hoisted
registry=https://registry.npmjs.org/

# Change pnpm 8 settings to pnpm 7
resolution-mode='highest'
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"url": "https://github.com/web-infra-dev/rspack"
},
"engines": {
"pnpm": "8.14.3"
"pnpm": "9.3.0"
},
"devDependencies": {
"@biomejs/biome": "1.8.0",
Expand Down Expand Up @@ -79,5 +79,5 @@
"webpack-cli": "4.10.0",
"why-is-node-running": "2.2.2"
},
"packageManager": "pnpm@8.14.3"
"packageManager": "pnpm@9.3.0"
}
Loading

2 comments on commit 4fcc42c

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ✅ success
rspress ❌ failure
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-06-11 34bb9ea) Current Change
10000_development-mode + exec 2.24 s ± 26 ms 2.23 s ± 29 ms -0.53 %
10000_development-mode_hmr + exec 737 ms ± 14 ms 734 ms ± 13 ms -0.39 %
10000_production-mode + exec 2.58 s ± 21 ms 2.59 s ± 34 ms +0.15 %
arco-pro_development-mode + exec 1.92 s ± 78 ms 1.92 s ± 84 ms +0.02 %
arco-pro_development-mode_hmr + exec 441 ms ± 1.3 ms 442 ms ± 2 ms +0.13 %
arco-pro_production-mode + exec 3.51 s ± 71 ms 3.54 s ± 59 ms +0.90 %
threejs_development-mode_10x + exec 1.41 s ± 15 ms 1.4 s ± 22 ms -0.22 %
threejs_development-mode_10x_hmr + exec 802 ms ± 6.9 ms 810 ms ± 6.1 ms +0.93 %
threejs_production-mode_10x + exec 4.71 s ± 20 ms 4.72 s ± 27 ms +0.24 %

Please sign in to comment.