Skip to content

Commit

Permalink
refactor(typescript): packages/rspack/src/builtin-plugin (#7378)
Browse files Browse the repository at this point in the history
  • Loading branch information
@shulaoda
shulaoda authored Jul 31, 2024
1 parent e4d6a23 commit 669c2f1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions packages/rspack/etc/api.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1898,9 +1898,9 @@ const ElectronTargetPlugin: {

// @public (undocumented)
const EnableChunkLoadingPlugin: {
new (type: any): {
new (type: string): {
name: BuiltinPluginName;
_args: [type: any];
_args: [type: string];
affectedHooks: "done" | "make" | "compile" | "emit" | "afterEmit" | "invalid" | "thisCompilation" | "afterDone" | "compilation" | "normalModuleFactory" | "contextModuleFactory" | "initialize" | "shouldEmit" | "infrastructureLog" | "beforeRun" | "run" | "assetEmitted" | "failed" | "shutdown" | "watchRun" | "watchClose" | "environment" | "afterEnvironment" | "afterPlugins" | "afterResolvers" | "beforeCompile" | "afterCompile" | "finishMake" | "entryOption" | undefined;
raw(compiler: Compiler_2): BuiltinPlugin;
apply(compiler: Compiler_2): void;
Expand Down Expand Up @@ -1940,9 +1940,9 @@ class EnableLibraryPlugin extends RspackBuiltinPlugin {

// @public (undocumented)
const EnableWasmLoadingPlugin: {
new (type: any): {
new (type: string): {
name: BuiltinPluginName;
_args: [type: any];
_args: [type: string];
affectedHooks: "done" | "make" | "compile" | "emit" | "afterEmit" | "invalid" | "thisCompilation" | "afterDone" | "compilation" | "normalModuleFactory" | "contextModuleFactory" | "initialize" | "shouldEmit" | "infrastructureLog" | "beforeRun" | "run" | "assetEmitted" | "failed" | "shutdown" | "watchRun" | "watchClose" | "environment" | "afterEnvironment" | "afterPlugins" | "afterResolvers" | "beforeCompile" | "afterCompile" | "finishMake" | "entryOption" | undefined;
raw(compiler: Compiler_2): BuiltinPlugin;
apply(compiler: Compiler_2): void;
Expand Down
2 changes: 1 addition & 1 deletion packages/rspack/src/builtin-plugin/EnableChunkLoadingPlugin.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import { create } from "./base";

export const EnableChunkLoadingPlugin = create(
BuiltinPluginName.EnableChunkLoadingPlugin,
type => type
(type: string): string => type
);
2 changes: 1 addition & 1 deletion packages/rspack/src/builtin-plugin/EnableWasmLoadingPlugin.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import { create } from "./base";

export const EnableWasmLoadingPlugin = create(
BuiltinPluginName.EnableWasmLoadingPlugin,
type => type
(type: string): string => type
);

2 comments on commit 669c2f1

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rsbuild ✅ success
examples ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-07-31 9e2cbe9) Current Change
10000_development-mode + exec 2.27 s ± 20 ms 2.24 s ± 41 ms -1.36 %
10000_development-mode_hmr + exec 702 ms ± 11 ms 699 ms ± 8.6 ms -0.35 %
10000_production-mode + exec 2.76 s ± 39 ms 2.7 s ± 29 ms -2.03 %
arco-pro_development-mode + exec 1.88 s ± 66 ms 1.88 s ± 98 ms -0.22 %
arco-pro_development-mode_hmr + exec 433 ms ± 1.7 ms 435 ms ± 1.5 ms +0.51 %
arco-pro_production-mode + exec 3.45 s ± 114 ms 3.37 s ± 89 ms -2.36 %
threejs_development-mode_10x + exec 1.75 s ± 25 ms 1.76 s ± 24 ms +1.02 %
threejs_development-mode_10x_hmr + exec 863 ms ± 8.3 ms 880 ms ± 6 ms +2.08 %
threejs_production-mode_10x + exec 5.49 s ± 26 ms 5.5 s ± 40 ms +0.20 %

Please sign in to comment.