fix: side effects plugin should not compute based on affected

crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs

@@ -656,6 +656,21 @@ async fn nmf_module(
 
 #[plugin_hook(CompilationOptimizeDependencies for SideEffectsFlagPlugin)]
 fn optimize_dependencies(&self, compilation: &mut Compilation) -> Result<Option<bool>> {
+  let affected_modules = compilation
+    .unaffected_modules_cache
+    .get_affected_modules_with_chunk_graph()
+    .lock()
+    .expect("should lock")
+    .clone();
+  dbg!(affected_modules);
+  // TODO: use affected module optimization
+  let mut modules: IdentifierSet = compilation
+    .get_module_graph()
+    .modules()
+    .keys()
+    .copied()
+    .collect();
+
   let mut modules: IdentifierSet = if compilation.options.new_incremental_enabled() {
     compilation
       .unaffected_modules_cache

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/foo.js

@@ -0,0 +1 @@
+export const v = 'foo'

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/index.js

@@ -0,0 +1,16 @@
+import {v as value} from "./module";
+
+let v = value;
+module.hot.accept('./module', () => {
+	v = value
+});
+
+it("should auto-reexport an ES6 imported value on accept with newTreeshaking", async function (done) {
+	expect(v).toBe("foo");
+	NEXT(
+		require("../../update")(done, true, () => {
+			expect(v).toBe("foo");
+			done();
+		})
+	);
+});

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/module.js

@@ -0,0 +1,7 @@
+import {v} from './reexports'
+v;
+export {v};
+----
+import {v} from './reexports'
+v;// no-op
+export {v};

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/package.json

@@ -0,0 +1,3 @@
+{
+  "sideEffects": false
+}

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports-deep.js

@@ -0,0 +1,2 @@
+import {v} from './foo';
+export {v};

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports.js

@@ -0,0 +1,2 @@
+import {v} from './reexports-deep';
+export {v};

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/rspack.config.js

@@ -0,0 +1,7 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	optimization: {
+		sideEffects: true,
+		providedExports: true,
+	}
+};