Skip to content

Commit

Permalink
test: fix css concat stats test (#7955)
Browse files Browse the repository at this point in the history
  • Loading branch information
ahabhgk authored Sep 23, 2024
1 parent d9730e6 commit 79d259f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,15 @@ orphan modules 141 bytes [orphan] 4 modules
Rspack x.x.x compiled successfully in X s"
`;
exports[`statsOutput statsOutput/css-concat-error should print correct stats for 1`] = `
"assets by status 49 bytes [cached] 1 asset
ERROR in × Module not found: Can't resolve './src' in 'Xdir/css-concat-error'
Rspack x.x.x compiled with 1 error in X s"
exports[`statsOutput statsOutput/css-concat should print correct stats for 1`] = `
"asset main.js 7.81 KiB [emitted] (name: main)
asset main.css 51 bytes [emitted] (name: main)
Entrypoint main 7.86 KiB = main.js 7.81 KiB main.css 51 bytes
runtime modules 6.47 KiB 6 modules
cacheable modules 20 bytes (javascript) 23 bytes (css)
./index.js 20 bytes [built] [code generated]
./foo.css 23 bytes [built] [code generated]
Rspack x.x.x compiled successfully in X s"
`;
exports[`statsOutput statsOutput/filename should print correct stats for 1`] = `
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const path = require("path");

/** @type {import("@rspack/core").Configuration} */
module.exports = {
entry: "./index.js",
optimization: {
concatenateModules: true,
minimize: false
Expand Down

2 comments on commit 79d259f

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-09-23 45a3997) Current Change
10000_development-mode + exec 2.25 s ± 35 ms 2.25 s ± 20 ms -0.03 %
10000_development-mode_hmr + exec 715 ms ± 26 ms 715 ms ± 6.7 ms -0.00 %
10000_production-mode + exec 2.89 s ± 22 ms 2.93 s ± 41 ms +1.10 %
arco-pro_development-mode + exec 1.85 s ± 70 ms 1.87 s ± 54 ms +1.20 %
arco-pro_development-mode_hmr + exec 437 ms ± 1.2 ms 437 ms ± 2.4 ms -0.14 %
arco-pro_production-mode + exec 3.31 s ± 98 ms 3.29 s ± 78 ms -0.67 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.35 s ± 70 ms 3.37 s ± 68 ms +0.80 %
threejs_development-mode_10x + exec 1.7 s ± 15 ms 1.71 s ± 22 ms +0.41 %
threejs_development-mode_10x_hmr + exec 795 ms ± 6.7 ms 789 ms ± 9.8 ms -0.68 %
threejs_production-mode_10x + exec 5.27 s ± 33 ms 5.28 s ± 27 ms +0.30 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success

Please sign in to comment.