Skip to content

Commit

Permalink
chore(ci): skip preview if no relevant code changes (#8023)
Browse files Browse the repository at this point in the history
  • Loading branch information
@shulaoda
shulaoda authored Sep 30, 2024
1 parent 2ef3086 commit a193dcd
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/preview-commit.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ jobs:
- "packages/rspack-cli/**"
build:
needs: [get-runner-labels]
needs: [get-runner-labels, check-changed]
if: needs.check-changed.outputs.changed == 'true'
strategy:
fail-fast: false # Build and test everything so we can look at all the errors
matrix:
Expand Down Expand Up @@ -65,7 +66,6 @@ jobs:
runs-on: ubuntu-latest
needs:
- build
- check-changed
steps:
- uses: actions/checkout@v4

Expand All @@ -87,5 +87,4 @@ jobs:
run: ls -R npm

- name: Release
if: needs.check-changed.outputs.changed == 'true'
run: npx pkg-pr-new publish --compact --pnpm './npm/*' './crates/node_binding' './packages/rspack' './packages/rspack-cli'

2 comments on commit a193dcd

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-09-30 b2ee5d1) Current Change
10000_development-mode + exec 2.18 s ± 33 ms 2.19 s ± 24 ms +0.58 %
10000_development-mode_hmr + exec 685 ms ± 11 ms 680 ms ± 9 ms -0.80 %
10000_production-mode + exec 2.77 s ± 64 ms 2.74 s ± 42 ms -0.89 %
arco-pro_development-mode + exec 1.83 s ± 85 ms 1.81 s ± 89 ms -1.42 %
arco-pro_development-mode_hmr + exec 435 ms ± 3.5 ms 435 ms ± 6.5 ms +0.14 %
arco-pro_production-mode + exec 3.15 s ± 105 ms 3.18 s ± 93 ms +0.89 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.2 s ± 85 ms 3.21 s ± 82 ms +0.46 %
threejs_development-mode_10x + exec 1.67 s ± 16 ms 1.67 s ± 16 ms -0.01 %
threejs_development-mode_10x_hmr + exec 782 ms ± 13 ms 779 ms ± 18 ms -0.42 %
threejs_production-mode_10x + exec 5.07 s ± 26 ms 5.07 s ± 29 ms 0.00 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

Please sign in to comment.