Skip to content

Commit

Permalink
fix: remove LightningCssMinimizerRspackPlugin exclude option default …
Browse files Browse the repository at this point in the history 
…value (#7811)

fix: remove LightningCssMinimizerRspackPlugin exclude option default value
  • Loading branch information
@noshower
noshower authored Sep 11, 2024
1 parent b89fb12 commit b1bf153
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 15 deletions.
14 changes: 7 additions & 7 deletions packages/rspack-test-tools/tests/__snapshots__/StatsAPI.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Object {
"main.js",
],
"filteredModules": undefined,
"hash": "333e59d94047c9b4ec6c",
"hash": "ef6849a04b135f983911",
"id": "909",
"idHints": Array [],
"initial": true,
Expand Down Expand Up @@ -176,7 +176,7 @@ Object {
"errorsCount": 0,
"filteredAssets": undefined,
"filteredModules": undefined,
"hash": "a156b269cd7b4340da9d",
"hash": "d27b1f8bbdf2e13f1b91",
"modules": Array [
Object {
"assets": Array [],
Expand Down Expand Up @@ -324,7 +324,7 @@ Object {
"main.js",
],
"filteredModules": undefined,
"hash": "a2024ddd80c1dac51782",
"hash": "eceae76a4802a119b192",
"id": "909",
"idHints": Array [],
"initial": true,
Expand Down Expand Up @@ -691,7 +691,7 @@ Object {
"errorsCount": 0,
"filteredAssets": undefined,
"filteredModules": undefined,
"hash": "959ba20161293349edf3",
"hash": "b2ef257387e69373f7b0",
"modules": Array [
Object {
"assets": Array [],
Expand Down Expand Up @@ -1458,7 +1458,7 @@ Object {
"files": Array [
"main.js",
],
"hash": "333e59d94047c9b4ec6c",
"hash": "ef6849a04b135f983911",
"id": "909",
"idHints": Array [],
"initial": true,
Expand Down Expand Up @@ -1714,7 +1714,7 @@ Object {
"main.js",
],
"filteredModules": undefined,
"hash": "add6ca394a084131cdb7",
"hash": "770328aa6786a7bd40f1",
"id": "909",
"idHints": Array [],
"initial": true,
Expand Down Expand Up @@ -2063,7 +2063,7 @@ exports.c = require(\\"./c?c=3\\");
"errorsCount": 0,
"filteredAssets": undefined,
"filteredModules": undefined,
"hash": "0e205cc26142ad8eade1",
"hash": "e5c3f8bfb19708a3a81e",
"modules": Array [
Object {
"assets": Array [],
Expand Down
2 changes: 1 addition & 1 deletion packages/rspack-test-tools/tests/statsAPICases/basic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ module.exports = {
entry ./fixtures/a
cjs self exports reference self [585] ./fixtures/a.js
Rspack compiled successfully (a156b269cd7b4340da9d)"
Rspack compiled successfully (d27b1f8bbdf2e13f1b91)"
`);
}
};
4 changes: 2 additions & 2 deletions packages/rspack-test-tools/tests/statsAPICases/chunks.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = {
"chunkB.js",
],
"filteredModules": undefined,
"hash": "9aa837bfaefd1fd4ec18",
"hash": "bf7629c34eadb1d16318",
"id": "250",
"idHints": Array [],
"initial": false,
Expand Down Expand Up @@ -144,7 +144,7 @@ module.exports = {
"main.js",
],
"filteredModules": undefined,
"hash": "ed56b5e4b83c81c60edf",
"hash": "c0a99515ebfa264f9f23",
"id": "909",
"idHints": Array [],
"initial": true,
Expand Down
6 changes: 1 addition & 5 deletions packages/rspack/src/builtin-plugin/LightningCssMiminizerRspackPlugin.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ export const LightningCssMinimizerRspackPlugin = create(
errorRecovery: options?.minimizerOptions?.errorRecovery ?? true,
unusedSymbols: options?.minimizerOptions?.unusedSymbols ?? [],
include: include ? toFeatures(include) : undefined,
exclude: exclude
? toFeatures(exclude)
: // exclude all features, avoid downgrade css syntax when minimize
// 1048575 = Features.Empty | Features.Nesting | ... | Features.LogicalProperties
1048575,
exclude: exclude ? toFeatures(exclude) : undefined,
targets: typeof targets === "string" ? [targets] : targets,
draft: draft ? { customMedia: draft.customMedia ?? false } : undefined,
nonStandard: nonStandard
Expand Down

2 comments on commit b1bf153

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-09-11 f5c6a1b) Current Change
10000_development-mode + exec 2.24 s ± 48 ms 2.24 s ± 26 ms -0.13 %
10000_development-mode_hmr + exec 722 ms ± 7.4 ms 724 ms ± 6.3 ms +0.29 %
10000_production-mode + exec 2.86 s ± 47 ms 2.84 s ± 35 ms -0.46 %
arco-pro_development-mode + exec 1.85 s ± 81 ms 1.85 s ± 70 ms +0.09 %
arco-pro_development-mode_hmr + exec 435 ms ± 4 ms 434 ms ± 4.3 ms -0.15 %
arco-pro_production-mode + exec 3.26 s ± 99 ms 3.25 s ± 72 ms -0.17 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.34 s ± 76 ms 3.31 s ± 75 ms -0.73 %
threejs_development-mode_10x + exec 1.68 s ± 13 ms 1.69 s ± 10 ms +0.15 %
threejs_development-mode_10x_hmr + exec 805 ms ± 13 ms 809 ms ± 7.5 ms +0.56 %
threejs_production-mode_10x + exec 5.19 s ± 23 ms 5.19 s ± 39 ms +0.16 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rslib ❌ failure
rsbuild ❌ failure
examples ✅ success

Please sign in to comment.