fix: duplate emit source map from child compiler

web-infra-dev · Sep 10, 2024 · eaa0bb1 · eaa0bb1
1 parent 8134f86
commit eaa0bb1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/crates/rspack_plugin_devtool/src/mapped_assets_cache.rs b/crates/rspack_plugin_devtool/src/mapped_assets_cache.rs
@@ -1,6 +1,6 @@
 use dashmap::DashMap;
 use futures::Future;
-use rspack_core::{CompilationAsset, CompilationAssets};
+use rspack_core::CompilationAsset;
 use rspack_error::{Error, Result};
 
 use crate::MappedAsset;
@@ -15,7 +15,7 @@ impl MappedAssetsCache {
 
   pub async fn use_cache<'a, F, R>(
     &self,
-    assets: &'a CompilationAssets,
+    assets: Vec<(&'a String, &'a CompilationAsset)>,
     map_assets: F,
   ) -> Result<Vec<MappedAsset>>
   where

diff --git a/crates/rspack_plugin_devtool/src/source_map_dev_tool_plugin.rs b/crates/rspack_plugin_devtool/src/source_map_dev_tool_plugin.rs
@@ -506,9 +506,14 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
   }
 
   let start = logger.time("collect source maps");
+  let raw_assets = compilation
+    .assets()
+    .iter()
+    .filter(|(_filename, asset)| asset.info.related.source_map.is_none())
+    .collect::<Vec<_>>();
   let mapped_asstes = self
     .mapped_assets_cache
-    .use_cache(compilation.assets(), |assets| {
+    .use_cache(raw_assets, |assets| {
       self.map_assets(compilation, &file_to_chunk, assets)
     })
     .await?;