Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: When the favicon path contains Chinese characters, HtmlRspackPlugin may fail to load the file! #9336

Closed
nuintun opened this issue Feb 17, 2025 · 0 comments · Fixed by #9348
Closed

[Bug]: When the favicon path contains Chinese characters, HtmlRspackPlugin may fail to load the file! #9336

nuintun opened this issue Feb 17, 2025 · 0 comments · Fixed by #9348

Comments

@nuintun
Copy link

nuintun commented Feb 17, 2025

System Info

System: Win11
Version: 1.2.3

Details

When the favicon path contains Chinese characters, HtmlRspackPlugin may fail to load the file!

Image

Reproduce link

No response

Reproduce Steps

Set favicon path contains Chinese characters and run build.
@nuintun nuintun added the pending triage The issue/PR is currently untouched. label Feb 17, 2025
@inottn inottn removed the pending triage The issue/PR is currently untouched. label Feb 17, 2025
@inottn inottn mentioned this issue Feb 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unnecessary path-to-URL conversion in html plugin inottn/rspack
2 participants
@nuintun @inottn