Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary path-to-URL conversion in html plugin #9348

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Feb 17, 2025

Summary

Fixes: #9336

I'm not sure why the path is being converted to a URL here. It doesn't appear to be required, and it could introduce issues.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 17, 2025
Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d33df1d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b35b7d9cda460008a598c2

Copy link

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #9348 will not alter performance

Comparing inottn:fix/html (d33df1d) with main (92ddee2)

Summary

✅ 7 untouched benchmarks

@h-a-n-a h-a-n-a requested a review from LingyuCoder February 18, 2025 10:07
Copy link
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LingyuCoder LingyuCoder merged commit e63a022 into web-infra-dev:main Feb 19, 2025
31 checks passed
@inottn inottn deleted the fix/html branch February 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When the favicon path contains Chinese characters, HtmlRspackPlugin may fail to load the file!
2 participants