fix: remove unnecessary path-to-URL conversion in html plugin

crates/rspack_core/Cargo.toml

@@ -69,7 +69,6 @@ swc_core = { workspace = true, features = [
 swc_node_comments = { workspace = true }
 tokio = { workspace = true, features = ["rt", "rt-multi-thread", "macros", "test-util", "parking_lot"] }
 tracing = { workspace = true }
-url = { workspace = true }
 ustr = { workspace = true }
 
 [dev-dependencies]

crates/rspack_core/src/utils/mod.rs

@@ -50,21 +50,6 @@ pub use self::source::*;
 pub use self::template::*;
 pub use self::to_path::to_path;
 
-pub fn parse_to_url(url: &str) -> url::Url {
-  if !url.contains(':') {
-    let mut construct_string = String::with_capacity("specifier:".len() + url.len());
-    construct_string += "specifier:";
-    construct_string += url;
-    url::Url::parse(&construct_string).unwrap_or_else(|_| {
-      panic!("Invalid specifier: {url}, please use a valid specifier or a valid url")
-    })
-  } else {
-    url::Url::parse(url).unwrap_or_else(|_| {
-      panic!("Invalid specifier: {url}, please use a valid specifier or a valid url")
-    })
-  }
-}
-
 /// join string component in a more human readable way
 /// e.g.
 /// ```

crates/rspack_plugin_html/src/asset.rs

@@ -11,7 +11,6 @@ use cow_utils::CowUtils;
 use itertools::Itertools;
 use rayon::prelude::*;
 use rspack_core::{
-  parse_to_url,
   rspack_sources::{RawBufferSource, RawStringSource, SourceExt},
   AssetInfo, Compilation, CompilationAsset, Filename, NoFilenameFn, PathData,
 };
@@ -328,14 +327,13 @@ pub fn create_favicon_asset(
   config: &HtmlRspackPluginOptions,
   compilation: &Compilation,
 ) -> Result<(String, CompilationAsset), miette::Error> {
-  let url = parse_to_url(favicon);
   let favicon_file_path = PathBuf::from(config.get_relative_path(compilation, favicon))
     .file_name()
     .expect("Should have favicon file name")
     .to_string_lossy()
     .to_string();
 
-  let resolved_favicon = AsRef::<Path>::as_ref(&compilation.options.context).join(url.path());
+  let resolved_favicon = AsRef::<Path>::as_ref(&compilation.options.context).join(favicon);
 
   fs::read(resolved_favicon)
     .context(format!(

crates/rspack_plugin_html/src/template.rs

@@ -2,7 +2,7 @@ use std::{fs, path::PathBuf};
 
 use anyhow::Context;
 use itertools::Itertools;
-use rspack_core::{parse_to_url, Compilation, CrossOriginLoading, Mode};
+use rspack_core::{Compilation, CrossOriginLoading, Mode};
 use rspack_dojang::{dojang::DojangOptions, Dojang, Operand};
 use rspack_error::{miette, AnyhowError};
 use rspack_paths::AssertUtf8;
@@ -41,7 +41,7 @@ impl HtmlTemplate {
         } else {
           TemplateRender::Template(content.clone())
         },
-        url: parse_to_url("template_content.html").path().to_string(),
+        url: "template_content.html".to_string(),
         filename: "template_content.html".to_string(),
         file_dependencies: vec![],
         parameters: None,
@@ -97,7 +97,7 @@ impl HtmlTemplate {
       } else {
         Ok(Self {
           render: TemplateRender::Template(default_template().to_owned()),
-          url: parse_to_url("default.html").path().to_string(),
+          url: "default.html".to_string(),
           filename: "default.html".to_string(),
           file_dependencies: vec![],
           parameters: None,

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-with-chinese-path/index.js

@@ -0,0 +1,11 @@
+const fs = require("fs");
+const path = require("path");
+
+it("html favicon with absolute path", () => {
+	const faviconPath = path.join(__dirname, "./favicon-图标.ico");
+	expect(fs.existsSync(faviconPath)).toBe(true);
+
+	const htmlPath = path.join(__dirname, "./index.html");
+	const htmlContent = fs.readFileSync(htmlPath, "utf-8");
+	expect(htmlContent).toContain('<link href="/favicon-图标.ico" rel="icon">');
+});

packages/rspack-test-tools/tests/configCases/builtins/html-favicon-with-chinese-path/rspack.config.js

@@ -0,0 +1,12 @@
+const path = require("path");
+const { rspack } = require("@rspack/core");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	plugins: [
+		new rspack.HtmlRspackPlugin({
+			publicPath: "/",
+			favicon: "./资源/favicon-图标.ico"
+		})
+	]
+};