chore(deps)!: bump swc_core to v46 #12032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
Contributor
📦 Binary Size-limit
❌ Size increased by 36.88KB from 47.81MB to 47.84MB (⬆️0.08%) |
CodSpeed Performance ReportMerging #12032 will not alter performanceComparing Summary
|
Contributor
|
📝 Benchmark detail: Open
|
CPunisher
force-pushed
the
10-29-chore/swc
branch
from
6d08ddb to
2ffc289
Compare
CPunisher
requested review from
LingyuCoder,
ahabhgk and
quininer
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the SWC (Speedy Web Compiler) core dependencies from version 45.0.1 to 46.0.2, along with related SWC ecosystem packages. This is a major infrastructure update that requires changes throughout the codebase to adapt to breaking API changes in how SWC handles string atoms and UTF-8 encoding.
Key changes:
- Upgrade of
swc_corefrom 45.0.1 to 46.0.2 and related SWC packages - Migration from
AtomtoWtf8Atomfor handling potentially invalid UTF-8 strings - Addition of
to_atom_lossy(),to_string_lossy(), andas_atom()conversions throughout the codebase - Test snapshot updates reflecting changes in code generation (variable naming in deconfliction scenarios)
Reviewed Changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates SWC package versions to 44.0.0-46.0.2 range, removes swc_ecma_lexer dependency |
| Cargo.lock | Lock file updates for new SWC versions and hstr 3.0.1 |
| pnpm-lock.yaml | Updates @swc/plugin-remove-console from 9.1.0 to 10.0.0 |
| tests/rspack-test/package.json | Updates @swc/plugin-remove-console dependency version |
| crates/swc_plugin_ts_collector/src/*.rs | Migrates from Atom to Wtf8Atom for enum handling and type exports |
| crates/rspack_plugin_javascript/src/**/*.rs | Adds lossy conversions for string literals and atoms throughout parser |
| crates/rspack_util/src/atom.rs | Adds ModuleExportNameExt trait for consistent atom access |
| crates/rspack_util/src/fx_hash.rs | Exports indexmap publicly |
| tests/rspack-test/statsAPICases/exports.js | Updates hash value in snapshot |
| tests/rspack-test/esmOutputCases/deconflict/**/*.snap.txt | Updates variable naming in snapshots |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
h-a-n-a
reviewed
Oct 30, 2025
| EnumMemberValue::Number(n) => Some(EvaluatedInlinableValue::new_number(n)), | ||
| EnumMemberValue::String(s) => Some(EvaluatedInlinableValue::new_string(s)), | ||
| EnumMemberValue::String(s) => Some(EvaluatedInlinableValue::new_string( | ||
| s.to_atom_lossy().into_owned(), |
Contributor
There was a problem hiding this comment.
Maybe we should use Wtf8Atom here? Enum values may contain unpaired surrogates.
h-a-n-a
reviewed
Oct 30, 2025
| pub fn eval_str(str: &Str) -> BasicEvaluatedExpression<'_> { | ||
| let mut res = BasicEvaluatedExpression::with_range(str.span().real_lo(), str.span().real_hi()); | ||
| res.set_string(str.value.to_string()); | ||
| res.set_string(str.value.to_string_lossy().to_string()); |
Contributor
There was a problem hiding this comment.
Maybe use Wtf8Atom or Wtf8Buf here for the string type?
h-a-n-a
reviewed
Oct 30, 2025
| EnumMemberValue::Unknown => None, | ||
| }; | ||
| (id, value) | ||
| (id.to_atom_lossy().into_owned(), value) |
Contributor
There was a problem hiding this comment.
Enum name would contain unpaired surrogates as well
chenjiahan
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump swc related crates.
.to_lossyboundary segmentation might not be optimal.Related links
breaking changes:
LiteralwithStringLiteralin JSXAttrValue type swc-project/swc#10763Checklist