fix: should not inject css prefetch/preload runtime when only prefetch/preload js chunks #12112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h javascript chunks
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables several previously disabled tests and refactors the get_child_ids_by_order method in the Rust core. The changes include:
- Enabling tests that were previously marked as "FIXME" or unstable
- Updating test assertions to match new behavior in prefetch/preload ordering
- Refactoring Rust code to simplify child chunk ID collection logic
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/hotCases/worker/remove-add-worker/test.filter.js | Removed file that was disabling the test |
| tests/rspack-test/hotCases/worker/remove-add-worker/test.config.js | Added Worker configuration to moduleScope |
| tests/rspack-test/hotCases/runtime/root-error/test.filter.js | Updated TODO message |
| tests/rspack-test/hotCases/loader-import-module/css/test.filter.js | Changed from disabled to enabled test |
| tests/rspack-test/hotCases/loader-import-module/css/stylesheet.css.js | Removed HMR accept calls |
| tests/rspack-test/configCases/web/prefetch-preload-module/index.mjs | Reordered test assertions for prefetch/preload |
| tests/rspack-test/configCases/web/prefetch-preload-module-only-js/test.filter.js | Removed file that was disabling the test |
| tests/rspack-test/configCases/web/prefetch-preload-module-only-js/index.mjs | Removed charset assertion |
| tests/rspack-test/configCases/css/prefetch-preload-module/index.mjs | Reordered test assertions |
| tests/rspack-test/configCases/css/import/test.filter.js | Updated TODO message |
| tests/rspack-test/configCases/css/import/test.config.js | Changed how STATS_I is accessed |
| tests/rspack-test/configCases/css/import/index.js | Updated import mechanism and helper function usage |
| tests/rspack-test/configCases/asset-modules/errored/test.filter.js | Updated TODO message |
| crates/rspack_core/src/chunk.rs | Refactored get_child_ids_by_order to inline logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 29.75KB from 47.90MB to 47.92MB (⬆️0.06%) |
CodSpeed Performance ReportMerging #12112 will not alter performanceComparing Summary
|
…h javascript chunks
…h javascript chunks
…h javascript chunks
Contributor
|
📝 Benchmark detail: Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should not inject css loading prefetch/preload runtime when only prefetch/preload js chunks.
Related links
Checklist