refactor(typescript): refactor packages/rspack/src/util from js to ts and esm
#7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
SoonIter
force-pushed
the
chore/rspack-util-js-to-ts
branch
from
5b46e92
to
e1440e9
Compare
|
Nice code, could you sign the CLA? |
SoonIter
changed the title
packages/rspack/src/util from js to ts and esm
jithyan
force-pushed
the
chore/rspack-util-js-to-ts
branch
from
e1440e9
to
3b1f5fd
Compare
@SoonIter I think my local commits were in my other account, maybe that's why the CLA signing didn't work? |
SoonIter
approved these changes
Jul 21, 2024
Yeah, you are right, it looks nice now, I'll merge it |
|
thanks 🫶🏻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses task refactor
packages/rspack/src/utilof issue:#7225
Checklist