Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typescript): packages/rspack/src/logging/runtime #7377

Merged
merged 4 commits into from
Jul 31, 2024
Merged

refactor(typescript): packages/rspack/src/logging/runtime #7377

merged 4 commits into from
Jul 31, 2024

Conversation

wxiaoyun
Copy link
Contributor

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 85e3e50
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66aa0cfd10227c000834f944

@wxiaoyun wxiaoyun requested a review from SoonIter July 31, 2024 08:15
SoonIter
SoonIter approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ❤️

@SoonIter SoonIter enabled auto-merge (squash) July 31, 2024 08:27
@SoonIter SoonIter self-assigned this Jul 31, 2024
auto-merge was automatically disabled July 31, 2024 10:07

Head branch was pushed to by a user without write access

@SoonIter SoonIter merged commit d32702b into web-infra-dev:main Jul 31, 2024
28 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

Assignees

@SoonIter SoonIter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxiaoyun @SoonIter