refactor(typescript): packages/rspack/src/util/StatsFactory

packages/rspack/src/stats/StatsFactory.ts

@@ -11,7 +11,11 @@ import type { JsStats, JsStatsError, JsStatsWarning } from "@rspack/binding";
 import { HookMap, SyncBailHook, SyncWaterfallHook } from "@rspack/lite-tapable";
 
 import type { Compilation } from "../Compilation";
-import { type Comparator, concatComparators } from "../util/comparators";
+import {
+	type AtLeastTwo,
+	type Comparator,
+	concatComparators
+} from "../util/comparators";
 import { type GroupConfig, smartGrouping } from "../util/smartGrouping";
 
 export type KnownStatsFactoryContext = {
@@ -286,8 +290,7 @@ export class StatsFactory {
 			);
 			if (comparators.length > 0) {
 				items.sort(
-					// @ts-expect-error number of arguments is correct
-					concatComparators(...comparators)
+					concatComparators(...(comparators as AtLeastTwo<Comparator>))
 				);
 			}
 
@@ -345,8 +348,7 @@ export class StatsFactory {
 			);
 			if (comparators2.length > 0) {
 				resultItems.sort(
-					// @ts-expect-error number of arguments is correct
-					concatComparators(...comparators2)
+					concatComparators(...(comparators2 as AtLeastTwo<Comparator>))
 				);
 			}
 

packages/rspack/src/util/comparators.ts

@@ -46,11 +46,13 @@ const concatComparatorsCache: TwoKeyWeakMap<
 	Comparator
 > = new TwoKeyWeakMap();
 
+export type AtLeastTwo<T> = [T, T, ...T[]];
+
 export const concatComparators = (
-	c1: Comparator,
-	c2: Comparator,
-	...cRest: Comparator[]
+	...comps: AtLeastTwo<Comparator>
 ): Comparator => {
+	const [c1, c2, ...cRest] = comps;
+
 	if (cRest.length > 0) {
 		const [c3, ...cRest2] = cRest;
 		return concatComparators(c1, concatComparators(c2, c3, ...cRest2));