fix: should create an empty codegen result for module that has failure in codegen #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
✅ Deploy Preview for rspack canceled.
|
JSerFeng
changed the title
JSerFeng
force-pushed
the
fix/concate-parse
branch
from
1e886b6
to
3d5f1c0
Compare
ahabhgk
reviewed
Sep 3, 2024
h-a-n-a
reviewed
Sep 4, 2024
JSerFeng
force-pushed
the
fix/concate-parse
branch
2 times, most recently
from
4ecb4ce
to
3c55ddd
Compare
JSerFeng
force-pushed
the
fix/concate-parse
branch
from
c1135fd
to
80627ec
Compare
ahabhgk
approved these changes
Sep 19, 2024
JSerFeng
added a commit
that referenced
this pull request
Sep 29, 2024
…e in codegen (#7777) fix: parse error in concatenatedModule should be emitted to diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7382
When
code_generationreturns anErr, we should push this error to diagnostics and keep a emptyCodegenerateResultlike webpackParse error in concatenatedModule should be added to compilation diagnostics.
Checklist