Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean dev server code #7794

Merged
merged 4 commits into from
Sep 13, 2024
Merged

refactor: clean dev server code #7794

merged 4 commits into from
Sep 13, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Sep 4, 2024 •
edited
Loading

Summary

  • should not override private methods, just add some alias
  • override the module.require.resolve in NodeModule instance of webpack-dev-server to redirect webpack server module request to rspack

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 4, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 911033d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e3e6f7d8213d00083884b5

@hardfist hardfist added this to the 1.1.0 milestone Sep 5, 2024
@hardfist hardfist mentioned this pull request Sep 9, 2024
Closed
2 tasks
@LingyuCoder LingyuCoder marked this pull request as ready for review September 12, 2024 09:31
@LingyuCoder LingyuCoder enabled auto-merge (squash) September 12, 2024 09:49
ahabhgk
ahabhgk previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingyuCoder LingyuCoder merged commit d7a15d8 into main Sep 13, 2024
28 checks passed
@LingyuCoder LingyuCoder deleted the feat/clean-dev-server branch September 13, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees

@LingyuCoder LingyuCoder

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LingyuCoder @ahabhgk @hardfist