Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add clarification to loader this.callback usage #7855

Merged
merged 3 commits into from
Sep 10, 2024
Merged

docs: add clarification to loader this.callback usage #7855

merged 3 commits into from
Sep 10, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Sep 10, 2024

Summary

Resolved #7846 (review)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: document release: document related release(mr only) labels Sep 10, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 0e532df
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e028e350ca2d00085e856e
😎 Deploy Preview https://deploy-preview-7855--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a enabled auto-merge (squash) September 10, 2024 11:09
@h-a-n-a h-a-n-a merged commit 0f49faf into main Sep 10, 2024
28 checks passed
@h-a-n-a h-a-n-a deleted the docs/callback branch September 10, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees

@h-a-n-a h-a-n-a

Labels
release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @chenjiahan