Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should provide full error message with error name when hideStack is set to true #7867

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Sep 11, 2024

Summary

Before

WARNING in ./lib.js
  ⚠ Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

ERROR in ./lib.js
  × Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

After

WARNING in ./lib.js
  ⚠ ModuleWarning: Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

ERROR in ./lib.js
  × ModuleError: Failed to load (from: <PROJECT_ROOT>/tests/diagnosticsCases/module-build-failed/loader-emit-hide-stack/my-loader.js)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3228af1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66e2933a90b63600080aa79a

@h-a-n-a h-a-n-a merged commit fa38b86 into main Sep 12, 2024
28 checks passed
@h-a-n-a h-a-n-a deleted the fix-diagnostic branch September 12, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants