fix: lightningCss default target use browserslist set #7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Sep 12, 2024
| @@ -37,7 +38,7 @@ export const LightningCssMinimizerRspackPlugin = create( | |||
| ): RawLightningCssMinimizerRspackPluginOptions => { | |||
| const { include, exclude, draft, nonStandard, pseudoClasses } = | |||
| options?.minimizerOptions ?? {}; | |||
| const targets = options?.minimizerOptions?.targets ?? "fully supports es6"; // last not support es module chrome version | |||
| const targets = options?.minimizerOptions?.targets ?? browserslist(null); | |||
There was a problem hiding this comment.
If there is no browserslist config, I think we should not change the default "fully supports es6". It is a potentially breaking change.
There was a problem hiding this comment.
And we should resolve the browserslist config in the Rust side for better performance. Similar to #7544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一些流行的库都是使用 browerslist 来配置 target, 例如 Babel、postcss-preset-env。
当前，rspack. LightningCssMinimizerRspackPlugin target 选项的默认值是”fully supports es6“，与 postcss-preset-env 默认 target 配置存在不一致。这种不一致，可能会让同时使用 postcss-loader 和 rspack.LightningCssMinimizerRspackPlugin 项目存在潜在问题。
因此，期望将 rspack. LightningCssMinimizerRspackPlugin 的 minimizerOptions 配置中的 target, 默认值也由 browerslist 指定。
此 PR 可能会引入破坏性更改，原因是项目未显示配置 target ，同时未使用 browserslist 的项目，target 默认值的兼容性会低于原先的 ”fully supports es6“。