Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add JSDoc & types to improve configuration.resolve types. #8029

Merged
merged 1 commit into from
Sep 30, 2024
Merged

refactor: add JSDoc & types to improve configuration.resolve types. #8029

merged 1 commit into from
Sep 30, 2024

Conversation

GiveMe-A-Name
Copy link
Member

Summary

  • Add type & JSDoc for configuration.resolve

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 766bc0d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66fa477d01841f00089a219e

@GiveMe-A-Name GiveMe-A-Name mentioned this pull request Sep 30, 2024
Open
@GiveMe-A-Name GiveMe-A-Name force-pushed the refactor/configuration-resolve-types branch from 92db092 to 766bc0d Compare September 30, 2024 06:38
chenjiahan
chenjiahan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 5c261d9 into main Sep 30, 2024
29 checks passed
@chenjiahan chenjiahan deleted the refactor/configuration-resolve-types branch September 30, 2024 06:54
@SoonIter SoonIter mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

@GiveMe-A-Name GiveMe-A-Name

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiveMe-A-Name @CLAassistant @chenjiahan